Do not update Composer twice #5261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi and thanks for your PR! I think this is happening on 2.15 as well, maybe you can target that branch? You removed both the self-update statements, do we not need one? |
|
Sure thing! We don't need not a one. Travis CI does that for us by default. |
sanmai
force-pushed
the
pr/2.16/composer2
branch
from
3a5a092
to
0d1f9ab
Compare
|
nice, thanks for the rebase and info 👍 |
|
No prob. It wasn't a mistake when this was added initially, just for the record. At that time Travis CI wouldn't update to Composer v2 because it wasn't released yet. |
|
Thank you @sanmai. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done already at the start of the build:
https://travis-ci.com/github/FriendsOfPHP/PHP-CS-Fixer/jobs/434729269#L182-L183
(It wasn't before.)