Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation to "yoda_style" sniff to convert Yoda style to non-Yoda style #5293

Merged
merged 1 commit into from Nov 26, 2020
Merged

Add documentation to "yoda_style" sniff to convert Yoda style to non-Yoda style #5293

merged 1 commit into from Nov 26, 2020

Conversation

Luc45
Copy link
Contributor

@Luc45 Luc45 commented Nov 23, 2020 •
edited

Add documentation to "yoda_style" sniff to convert Yoda style to non-Yoda style

Relevant issue: #5281
Old PR: #5286

PS: Base branch is 2.16, not master

@Luc45 Luc45 mentioned this pull request Nov 23, 2020
Closed
@Luc45 Luc45 changed the title Add documentation to "yoda_style" sniff to convert Yoda conditionals to regular conditionals Add documentation to "yoda_style" sniff to convert Yoda style to non-Yoda style Nov 23, 2020
@SpacePossum SpacePossum added this to the 2.16.8 milestone Nov 26, 2020
@SpacePossum SpacePossum added the RTM Ready To Merge label Nov 26, 2020
@SpacePossum
Copy link
Contributor

SpacePossum commented Nov 26, 2020 •
edited

@Luc45 thanks for the PR and changes, looking good! Thanks for the reviews as well people.
@Luc45 can you maybe squash your commits into one? Let me know, otherwise I can do it later.

@Luc45
Add non-Yoda docs
e84afee 
Generate docs


Remove unnecessary description


Minor typo for consistency


CR: Remove the word "regular"


CR: Reword yoda sniff summary


Minor wording tweak
@Luc45
Copy link
Contributor Author

Luc45 commented Nov 26, 2020 •
edited

@SpacePossum I have undone the merge and squashed the commits.

@SpacePossum
Copy link
Contributor

thanks @Luc45 , looking all good 👍

@keradus keradus removed the RTM Ready To Merge label Nov 26, 2020
@keradus
Copy link
Member

keradus commented Nov 26, 2020

Thank you @Luc45.

@keradus keradus merged commit d333104 into PHP-CS-Fixer:2.16 Nov 26, 2020
@Luc45 Luc45 mentioned this pull request May 5, 2022
Closed
@alexandre-le-borgne
Copy link

alexandre-le-borgne commented Jun 28, 2023 •
edited

Merci khouya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawerlos kubawerlos kubawerlos approved these changes

@keradus keradus Awaiting requested review from keradus

Assignees
No one assigned
Labels
kind/enhancement topic/documentation
Projects
None yet
Milestone
2.16.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Luc45 @SpacePossum @keradus @alexandre-le-borgne @kubawerlos