Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further BC cleanup for 3.0 #5417

Merged
merged 1 commit into from Jan 9, 2021
Merged

Further BC cleanup for 3.0 #5417

merged 1 commit into from Jan 9, 2021

Conversation

keradus
Copy link
Member

@keradus keradus commented Jan 9, 2021

No description provided.

@keradus keradus added this to the 3.0.0 milestone Jan 9, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.009% when pulling 95ba38e on keradus:3.0_bc_cleanup into fd4bac1 on FriendsOfPHP:3.0.

@keradus keradus merged commit b8f2789 into PHP-CS-Fixer:3.0 Jan 9, 2021
@keradus keradus deleted the 3.0_bc_cleanup branch January 9, 2021 23:19
@SpacePossum
Copy link
Contributor

I wonder with will happen with fabbot;
https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/3.0/.php_cs.dist#L42

       ->useRuleSet(new PhpCsFixer\RuleSet($config->getRules()));

I tried updating the .php_cs.dist for fabbot before, however the sandbox fabbot is running in doesn't allow the new class as it seems to have PhpCsFixer\RuleSet explicitly listed as OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/BC break kind/cleanup
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keradus @coveralls @SpacePossum