Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META] 3.0 - old PHP versions cleanup #5519

Closed
wants to merge 14 commits into from
Closed

[META] 3.0 - old PHP versions cleanup #5519

wants to merge 14 commits into from

Conversation

keradus
Copy link
Member

@keradus keradus commented Mar 1, 2021 •
edited
Loading

best to review commit by commit
but I also tried to extract to separated PR as much as possible, so this PR shouldn't contain logic changes

direction aligned within maintainers team

extracted:

@keradus keradus added this to the 3.0.0 milestone Mar 1, 2021
@keradus keradus marked this pull request as draft March 1, 2021 15:07
@keradus keradus force-pushed the 3.0_BUMP branch 2 times, most recently from 3897c41 to 8397733 Compare March 1, 2021 15:13
keradus
keradus commented Mar 1, 2021
View reviewed changes
TODO Outdated
@@ -0,0 +1,14 @@
- [x] bump min version in entry file
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is execution plan

@keradus keradus marked this pull request as ready for review March 1, 2021 20:19
@coveralls
Copy link

coveralls commented Mar 1, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 91.936% when pulling 85efa05 on keradus:3.0_BUMP into 55158a6 on FriendsOfPHP:3.0.

This was referenced Mar 1, 2021
Merged
Merged
Merged
keradus added a commit that referenced this pull request Mar 2, 2021
@keradus
minor #5522 Token - add handling json_encode crash (keradus)
a2aee2f 
This PR was squashed before being merged into the 2.18 branch.

Discussion
----------

Token - add handling json_encode crash

#5519 will crash without it, as we would be returning false (indicating json_encode error) instead of string

Commits
-------

d0cf535 Token - add handling json_encode crash
@keradus keradus force-pushed the 3.0_BUMP branch 3 times, most recently from beed013 to 25fd548 Compare March 3, 2021 16:18
keradus added a commit that referenced this pull request Mar 3, 2021
@keradus
minor #5521 DX: apply rules configuration cleanups for PHP 7.1+ (kera…
fda4bdf 
…dus)

This PR was squashed before being merged into the 3.0 branch.

Discussion
----------

DX: apply rules configuration cleanups for PHP 7.1+

PR is ready, but depends on #5519

Commits
-------

82f5857 DX: apply rules configuration cleanups for PHP 7.1+
@keradus keradus force-pushed the 3.0_BUMP branch 4 times, most recently from 1f3c79a to 6f23c06 Compare March 5, 2021 11:30
@keradus
Copy link
Member Author

keradus commented Mar 7, 2021

Closing, as everything got extracted

@keradus keradus closed this Mar 7, 2021
@keradus keradus deleted the 3.0_BUMP branch March 7, 2021 20:00
@keradus keradus removed this from the 3.0.0 milestone Mar 7, 2021
@keradus keradus changed the title 3.0 - old PHP versions cleanup [META] 3.0 - old PHP versions cleanup Mar 7, 2021
@keradus keradus added the kind/meta Set of actions to be broken down into single issues/PR's label Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/meta Set of actions to be broken down into single issues/PR's
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keradus @coveralls