Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: further typing improvements #5555

Merged
merged 1 commit into from Mar 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Cache/FileCacheManager.php
Expand Up @@ -61,7 +61,7 @@ public function __construct(
FileHandlerInterface $handler,
SignatureInterface $signature,
bool $isDryRun = false,
DirectoryInterface $cacheDirectory = null
?DirectoryInterface $cacheDirectory = null
) {
$this->handler = $handler;
$this->signature = $signature;
Expand Down
2 changes: 1 addition & 1 deletion src/Console/Command/DescribeCommand.php
Expand Up @@ -64,7 +64,7 @@ final class DescribeCommand extends Command
*/
private $fixers;

public function __construct(FixerFactory $fixerFactory = null)
public function __construct(?FixerFactory $fixerFactory = null)
{
parent::__construct();

Expand Down
2 changes: 1 addition & 1 deletion src/Differ/DifferInterface.php
Expand Up @@ -22,5 +22,5 @@ interface DifferInterface
/**
* Create diff.
*/
public function diff(string $old, string $new, \SplFileInfo $file = null): string;
public function diff(string $old, string $new, ?\SplFileInfo $file = null): string;
}
2 changes: 1 addition & 1 deletion src/Differ/FullDiffer.php
Expand Up @@ -43,7 +43,7 @@ public function __construct()
/**
* {@inheritdoc}
*/
public function diff(string $old, string $new, \SplFileInfo $file = null): string
public function diff(string $old, string $new, ?\SplFileInfo $file = null): string
{
return $this->differ->diff($old, $new);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Differ/NullDiffer.php
Expand Up @@ -22,7 +22,7 @@ final class NullDiffer implements DifferInterface
/**
* {@inheritdoc}
*/
public function diff(string $old, string $new, \SplFileInfo $file = null): string
public function diff(string $old, string $new, ?\SplFileInfo $file = null): string
{
return '';
}
Expand Down
2 changes: 1 addition & 1 deletion src/Differ/UnifiedDiffer.php
Expand Up @@ -26,7 +26,7 @@ final class UnifiedDiffer implements DifferInterface
/**
* {@inheritdoc}
*/
public function diff(string $old, string $new, \SplFileInfo $file = null): string
public function diff(string $old, string $new, ?\SplFileInfo $file = null): string
{
if (null === $file) {
$options = [
Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/Alias/NoAliasFunctionsFixer.php
Expand Up @@ -99,7 +99,7 @@ final class NoAliasFunctionsFixer extends AbstractFixer implements ConfigurableF
'gmmktime' => ['time', 0],
];

public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/Basic/PsrAutoloadingFixer.php
Expand Up @@ -68,7 +68,7 @@ class InvalidName {}
/**
* {@inheritdoc}
*/
public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/Casing/ConstantCaseFixer.php
Expand Up @@ -43,7 +43,7 @@ final class ConstantCaseFixer extends AbstractFixer implements ConfigurableFixer
/**
* {@inheritdoc}
*/
public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
Expand Up @@ -160,7 +160,7 @@ private function fixFunctionReturnType(Tokens $tokens, int $index): void
$this->fixArgumentType($tokens, $this->functionsAnalyzer->getFunctionReturnType($tokens, $index));
}

private function fixArgumentType(Tokens $tokens, TypeAnalysis $type = null): void
private function fixArgumentType(Tokens $tokens, ?TypeAnalysis $type = null): void
{
if (null === $type) {
return;
Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/Comment/CommentToPhpdocFixer.php
Expand Up @@ -86,7 +86,7 @@ public function getDefinition(): FixerDefinitionInterface
/**
* {@inheritdoc}
*/
public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
Expand Up @@ -125,7 +125,7 @@ public function isRisky(): bool
/**
* {@inheritdoc}
*/
public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/FunctionNotation/MethodArgumentSpaceFixer.php
Expand Up @@ -109,7 +109,7 @@ public function isCandidate(Tokens $tokens): bool
return $tokens->isTokenKindFound('(');
}

public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
Expand Up @@ -62,7 +62,7 @@ final class NativeFunctionInvocationFixer extends AbstractFixer implements Confi
*/
private $functionFilter;

public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
Expand Up @@ -105,7 +105,7 @@ final class SingleSpaceAfterConstructFixer extends AbstractFixer implements Conf
/**
* {@inheritdoc}
*/
public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/Operator/OperatorLinebreakFixer.php
Expand Up @@ -85,7 +85,7 @@ function foo() {
/**
* {@inheritdoc}
*/
public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/PhpUnit/PhpUnitMockFixer.php
Expand Up @@ -88,7 +88,7 @@ public function isRisky(): bool
/**
* {@inheritdoc}
*/
public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/PhpUnit/PhpUnitNoExpectationAnnotationFixer.php
Expand Up @@ -44,7 +44,7 @@ final class PhpUnitNoExpectationAnnotationFixer extends AbstractPhpUnitFixer imp
/**
* {@inheritdoc}
*/
public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/Phpdoc/PhpdocNoAliasTagFixer.php
Expand Up @@ -85,7 +85,7 @@ public function getPriority(): int
return parent::getPriority();
}

public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/Phpdoc/PhpdocTagCasingFixer.php
Expand Up @@ -55,7 +55,7 @@ public function getPriority(): int
return parent::getPriority();
}

public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
2 changes: 1 addition & 1 deletion src/Fixer/Phpdoc/PhpdocTypesFixer.php
Expand Up @@ -76,7 +76,7 @@ final class PhpdocTypesFixer extends AbstractPhpdocTypesFixer implements Configu
/**
* {@inheritdoc}
*/
public function configure(array $configuration = null): void
public function configure(array $configuration): void
{
parent::configure($configuration);

Expand Down
6 changes: 3 additions & 3 deletions src/FixerConfiguration/FixerOption.php
Expand Up @@ -60,9 +60,9 @@ public function __construct(
string $description,
bool $isRequired = true,
$default = null,
array $allowedTypes = null,
array $allowedValues = null,
\Closure $normalizer = null
?array $allowedTypes = null,
?array $allowedValues = null,
?\Closure $normalizer = null
) {
if ($isRequired && null !== $default) {
throw new \LogicException('Required options cannot have a default value.');
Expand Down
2 changes: 1 addition & 1 deletion src/FixerDefinition/CodeSample.php
Expand Up @@ -29,7 +29,7 @@ final class CodeSample implements CodeSampleInterface
*/
private $configuration;

public function __construct(string $code, array $configuration = null)
public function __construct(string $code, ?array $configuration = null)
{
$this->code = $code;
$this->configuration = $configuration;
Expand Down
2 changes: 1 addition & 1 deletion src/FixerDefinition/FileSpecificCodeSample.php
Expand Up @@ -34,7 +34,7 @@ final class FileSpecificCodeSample implements FileSpecificCodeSampleInterface
public function __construct(
string $code,
\SplFileInfo $splFileInfo,
array $configuration = null
?array $configuration = null
) {
$this->codeSample = new CodeSample($code, $configuration);
$this->splFileInfo = $splFileInfo;
Expand Down
2 changes: 1 addition & 1 deletion src/FixerDefinition/VersionSpecificCodeSample.php
Expand Up @@ -32,7 +32,7 @@ final class VersionSpecificCodeSample implements VersionSpecificCodeSampleInterf
public function __construct(
string $code,
VersionSpecificationInterface $versionSpecification,
array $configuration = null
?array $configuration = null
) {
$this->codeSample = new CodeSample($code, $configuration);
$this->versionSpecification = $versionSpecification;
Expand Down
2 changes: 1 addition & 1 deletion src/Linter/TokenizerLintingResult.php
Expand Up @@ -26,7 +26,7 @@ final class TokenizerLintingResult implements LintingResultInterface
*/
private $error;

public function __construct(\Error $error = null)
public function __construct(?\Error $error = null)
{
$this->error = $error;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Runner/FileFilterIterator.php
Expand Up @@ -44,7 +44,7 @@ final class FileFilterIterator extends \FilterIterator

public function __construct(
\Traversable $iterator,
EventDispatcherInterface $eventDispatcher = null,
?EventDispatcherInterface $eventDispatcher,
CacheManagerInterface $cacheManager
) {
if (!$iterator instanceof \Iterator) {
Expand Down
4 changes: 2 additions & 2 deletions src/Runner/Runner.php
Expand Up @@ -91,12 +91,12 @@ public function __construct(
$finder,
array $fixers,
DifferInterface $differ,
EventDispatcherInterface $eventDispatcher = null,
?EventDispatcherInterface $eventDispatcher,
ErrorsManager $errorsManager,
LinterInterface $linter,
$isDryRun,
CacheManagerInterface $cacheManager,
DirectoryInterface $directory = null,
?DirectoryInterface $directory = null,
$stopOnViolation = false
) {
$this->finder = $finder;
Expand Down
4 changes: 2 additions & 2 deletions src/Tokenizer/Analyzer/Analysis/ArgumentAnalysis.php
Expand Up @@ -43,11 +43,11 @@ final class ArgumentAnalysis
/**
* The type analysis of the argument.
*
* @var null|TypeAnalysis
* @var ?TypeAnalysis
*/
private $typeAnalysis;

public function __construct(string $name, int $nameIndex, ?string $default, TypeAnalysis $typeAnalysis = null)
public function __construct(string $name, int $nameIndex, ?string $default, ?TypeAnalysis $typeAnalysis = null)
{
$this->name = $name;
$this->nameIndex = $nameIndex;
Expand Down
2 changes: 1 addition & 1 deletion src/Tokenizer/Token.php
Expand Up @@ -438,7 +438,7 @@ public function toArray(): array
/**
* @param null|string[] $options JSON encode option
*/
public function toJson(array $options = null): string
public function toJson(?array $options = null): string
{
static $defaultOptions = null;

Expand Down
2 changes: 1 addition & 1 deletion src/Tokenizer/Tokens.php
Expand Up @@ -705,7 +705,7 @@ public function getPrevMeaningfulToken(int $index): ?int
*
* @return null|array<int, Token> an array containing the tokens matching the sequence elements, indexed by their position
*/
public function findSequence(array $sequence, int $start = 0, int $end = null, $caseSensitive = true): ?array
public function findSequence(array $sequence, int $start = 0, ?int $end = null, $caseSensitive = true): ?array
{
$sequenceCount = \count($sequence);
if (0 === $sequenceCount) {
Expand Down
Expand Up @@ -1249,7 +1249,7 @@ abstract public static function absPubStatFunc1();
* @dataProvider provideFix74Cases
* @requires PHP 7.4
*/
public function testFix74(string $expected, ?string $input = null, array $configuration = null): void
public function testFix74(string $expected, ?string $input = null, ?array $configuration = null): void
{
if (null !== $configuration) {
$this->fixer->configure($configuration);
Expand Down
2 changes: 1 addition & 1 deletion tests/Fixer/ControlStructure/YodaStyleFixerTest.php
Expand Up @@ -937,7 +937,7 @@ public function provideFixPhp74Cases()
* @dataProvider providePHP74Cases
* @requires PHP 7.4
*/
public function testPHP74CasesInverse(string $expected, ?string $input = null, array $configuration = null): void
public function testPHP74CasesInverse(string $expected, ?string $input = null, ?array $configuration = null): void
{
if (null !== $configuration) {
$this->fixer->configure($configuration);
Expand Down
2 changes: 1 addition & 1 deletion tests/Fixer/Operator/BinaryOperatorSpacesFixerTest.php
Expand Up @@ -2008,7 +2008,7 @@ function A(){}[$a] = $a[$c];
* @dataProvider provideFixPhp74Cases
* @requires PHP 7.4
*/
public function testFixPhp74(string $expected, ?string $input = null, array $configuration = null): void
public function testFixPhp74(string $expected, ?string $input = null, ?array $configuration = null): void
{
if (null !== $configuration) {
$this->fixer->configure($configuration);
Expand Down
4 changes: 2 additions & 2 deletions tests/Fixer/Operator/OperatorLinebreakFixerTest.php
Expand Up @@ -28,7 +28,7 @@ final class OperatorLinebreakFixerTest extends AbstractFixerTestCase
/**
* @dataProvider provideFixCases
*/
public function testFix(string $expected, ?string $input = null, array $configuration = null): void
public function testFix(string $expected, ?string $input = null, ?array $configuration = null): void
{
if (null !== $configuration) {
$this->fixer->configure($configuration);
Expand Down Expand Up @@ -196,7 +196,7 @@ function foo()
*
* @requires PHP 7.1
*/
public function testFix71(string $expected, ?string $input = null, array $configuration = null): void
public function testFix71(string $expected, ?string $input = null, ?array $configuration = null): void
{
if (null !== $configuration) {
$this->fixer->configure($configuration);
Expand Down
2 changes: 1 addition & 1 deletion tests/Fixer/Phpdoc/GeneralPhpdocTagRenameFixerTest.php
Expand Up @@ -27,7 +27,7 @@ final class GeneralPhpdocTagRenameFixerTest extends AbstractFixerTestCase
/**
* @dataProvider provideFixCases
*/
public function testFix(string $expected, ?string $input = null, array $configuration = null): void
public function testFix(string $expected, ?string $input = null, ?array $configuration = null): void
{
if (null !== $configuration) {
$this->fixer->configure($configuration);
Expand Down
2 changes: 1 addition & 1 deletion tests/Fixer/Phpdoc/PhpdocInlineTagNormalizerFixerTest.php
Expand Up @@ -26,7 +26,7 @@ final class PhpdocInlineTagNormalizerFixerTest extends AbstractFixerTestCase
/**
* @dataProvider provideFixCases
*/
public function testFix(string $expected, ?string $input = null, array $configuration = null): void
public function testFix(string $expected, ?string $input = null, ?array $configuration = null): void
{
if (null !== $configuration) {
$this->fixer->configure($configuration);
Expand Down
2 changes: 1 addition & 1 deletion tests/Fixer/Phpdoc/PhpdocTagTypeFixerTest.php
Expand Up @@ -27,7 +27,7 @@ final class PhpdocTagTypeFixerTest extends AbstractFixerTestCase
/**
* @dataProvider provideFixCases
*/
public function testFix(string $expected, ?string $input = null, array $configuration = null): void
public function testFix(string $expected, ?string $input = null, ?array $configuration = null): void
{
if (null !== $configuration) {
$this->fixer->configure($configuration);
Expand Down