Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassAttributesSeparationFixer - fix for using visibility for class elements #5617

Merged
merged 1 commit into from Apr 14, 2021
Merged

ClassAttributesSeparationFixer - fix for using visibility for class elements #5617

merged 1 commit into from Apr 14, 2021

Conversation

kubawerlos
Copy link
Contributor

In the 2 added test cases, the 1st one (without visibilities) is passing and the 2nd one (with visibilities) is failing.

@kubawerlos kubawerlos marked this pull request as ready for review April 11, 2021 16:07
@kubawerlos kubawerlos added this to the 2.18.6 milestone Apr 11, 2021
@coveralls
Copy link

coveralls commented Apr 11, 2021

Coverage Status

Coverage increased (+0.0004%) to 91.857% when pulling bdb85f5 on kubawerlos:fix_ClassAttributesSeparationFixer into 7a21d69 on FriendsOfPHP:2.18.

@keradus
Copy link
Member

keradus commented Apr 14, 2021

Thank you @kubawerlos.

@keradus keradus merged commit a9c7540 into PHP-CS-Fixer:2.18 Apr 14, 2021
@kubawerlos kubawerlos deleted the fix_ClassAttributesSeparationFixer branch April 14, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants