GetClassToClassKeywordFixer - introduction

[paulbalandan]

$ php php-cs-fixer describe get_class_to_class_keyword`

Description of get_class_to_class_keyword rule.
Replace `get_class` calls on object variables with class keyword syntax.

Fixer applying this rule is risky.
Risky if the `get_class` function is overridden.

Fixing examples:
 * Example #1.
   ---------- begin diff ----------
   --- Original
   +++ New
   @@ -1,2 +1,2 @@
    <?php
   -get_class($a);
   +$a::class;

   ----------- end diff -----------

 * Example #2.
   ---------- begin diff ----------
   --- Original
   +++ New
   @@ -1,4 +1,4 @@
    <?php

    $date = new \DateTimeImmutable();
   -$class = get_class($date);
   +$class = $date::class;

   ----------- end diff -----------

[coveralls]

Coverage increased (+0.01%) to 93.039% when pulling ee541a6 on paulbalandan:get-class-to-class-keyword into ea5a185 on FriendsOfPHP:master.

[julienfalque]

I always considered accessing class constants via object instances a hacky/bad practice, is it not?

[keradus]

I would agree if we talk about class constant defined as part of class.
I would rather treat ::class as language keyword in this context.

• you cannot create class constant inside class (Fatal error: A class constant must not be called 'class'; it is reserved for class)
• calling ::class is also one extra opCode tan calling regular class-level constant (showing it's slightly different concept under the hood) ref

[SpacePossum]

looking good! 👍
currently blocked by #6058

[SpacePossum]

Thank you @paulbalandan.

[paulbalandan]

Thanks, @SpacePossum