Fix tests and CS#6171
Merged
SpacePossum merged 1 commit intoPHP-CS-Fixer:masterfrom Dec 14, 2021
SpacePossum:master_failing_tests
Merged
Fix tests and CS#6171SpacePossum merged 1 commit intoPHP-CS-Fixer:masterfrom SpacePossum:master_failing_tests
SpacePossum merged 1 commit intoPHP-CS-Fixer:masterfrom
SpacePossum:master_failing_tests
Conversation
keradus
reviewed
Dec 14, 2021
| FAST_LINT_TEST_CASES: ${{ matrix.FAST_LINT_TEST_CASES }} | ||
| run: vendor/bin/phpunit ${{ matrix.phpunit-flags }} | ||
| run: | | ||
| php -v |
Member
There was a problem hiding this comment.
@SpacePossum
why we need this?
isn't it already part of the workflow, to set up configured version of PHP?
Contributor
Author
There was a problem hiding this comment.
yeah if test locally work but no gitlab it is very much handly to know the patch version (like 8.0.0 vs. 8.0.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.