Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 - handle enums in class fixers #6219

Closed
wants to merge 1 commit into from
Closed

PHP 8.1 - handle enums in class fixers #6219

wants to merge 1 commit into from

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Jan 3, 2022 •
edited

This pull request…

  • adds T_ENUM to Token::getClassyTokenKinds() ($token->isClassy() returns true for enums)
  • adds enum cases to TokenAnalyzer::findClassyElements()
  • adds test cases and some fixes for enums for ClassDefinitionFixer, BracesFixer, OrderedClassElementsFixer

@coveralls
Copy link

coveralls commented Jan 3, 2022 •
edited

Coverage Status

Coverage decreased (-0.01%) to 93.016% when pulling 31c09ab on gharlan:enums into efeab76 on FriendsOfPHP:master.

@SpacePossum
Copy link
Contributor

thanks for all the work :) please rebase, maybe we can have 2 PR's, one for BracesFixer and one for OrderedClassElementsFixer ?

This was referenced Feb 20, 2022
Merged
Merged
@gharlan gharlan closed this Feb 20, 2022
@gharlan gharlan deleted the enums branch February 20, 2022 12:11
SpacePossum added a commit that referenced this pull request Feb 20, 2022
@SpacePossum
feature #6300 OrderedClassElementsFixer - handle enums (gharlan)
602f501 
This PR was merged into the master branch.

Discussion
----------

OrderedClassElementsFixer - handle enums

extracted from #6219

Commits
-------

05fe704 OrderedClassElementsFixer - handle enums
SpacePossum added a commit that referenced this pull request Feb 20, 2022
@SpacePossum
minor #6301 BracesFixer - handle enums (gharlan)
b05de2e 
This PR was merged into the master branch.

Discussion
----------

BracesFixer - handle enums

extracted from #6219

Commits
-------

61a5df7 BracesFixer - handle enums
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gharlan @coveralls @SpacePossum