feature: TrailingCommaInMultilineFixer - Add array destructuring support #6518
Conversation
SpacePossum
force-pushed
the
master_TrailingCommaInMultilineFixer_add_array_destructuring
branch
from
1406168
to
6a21a18
Compare
| Using the `@Symfony <./../../ruleSets/Symfony.rst>`_ rule set will enable the ``trailing_comma_in_multiline`` rule with the default config. | ||
| Using the `@Symfony <./../../ruleSets/Symfony.rst>`_ rule set will enable the ``trailing_comma_in_multiline`` rule with the config below: | ||
|
|
||
| ``['elements' => ['array_destructuring', 'arrays', 'match']]`` |
There was a problem hiding this comment.
The default value (as was previously used) is ['arrays'].
There was a problem hiding this comment.
This is a new rule, as such there is no "previously used"?
There was a problem hiding this comment.
This is a new rule
Not sure I follow you. What makes you think the rule is new?
Anyway, the @Symfony ruleset isn't new so it shouldn't change. But actually Symfony might be OK with this? @nicolas-grekas What do you think?
There was a problem hiding this comment.
trailing_comma_in_multiline rule is already on master, so it is not a new rule indeed
yet, the configuration of it for Sf ruleset changed - not sure if it's welcome by Sf community, did we checked if repo follows this new rule already, or checked with maintainers?
There was a problem hiding this comment.
I confused this PR with another, sorry about that.
The changes on SF 5.4 would look like this:
https://github.com/SpacePossum/symfony/pull/2/files
SpacePossum
force-pushed
the
master_TrailingCommaInMultilineFixer_add_array_destructuring
branch
3 times, most recently
from
a78178c
to
3cf2793
Compare
|
rebased on latest, fixed conflict, moved back some stuff (#6518 (comment)), no other changes |
SpacePossum
force-pushed
the
master_TrailingCommaInMultilineFixer_add_array_destructuring
branch
from
3cf2793
to
5537a92
Compare
|
rebased on latest, no other changes |
SpacePossum
force-pushed
the
master_TrailingCommaInMultilineFixer_add_array_destructuring
branch
from
5537a92
to
eb340fe
Compare
|
rebased on latest, no other changes |
SpacePossum
deleted the
master_TrailingCommaInMultilineFixer_add_array_destructuring
branch
No description provided.