feature: PHP8.2 - "readonly" class support #6624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacePossum
changed the title
SpacePossum
force-pushed
the
m_readonly_class_support
branch
from
5e9e66c
to
bd0efaf
Compare
SpacePossum
force-pushed
the
m_readonly_class_support
branch
4 times, most recently
from
ae53bc7
to
2e96eac
Compare
SpacePossum
force-pushed
the
m_readonly_class_support
branch
3 times, most recently
from
28ede6c
to
980360f
Compare
|
@SpacePossum we should wait for #6621 to be merged, then rebase this one and change fixture in integration test, so keywords are in wrong order (now only casing is verified, order is preserved). |
|
There is a utest for the feature to order, so there is no need to wait. |
SpacePossum
force-pushed
the
m_readonly_class_support
branch
2 times, most recently
from
69abed4
to
358988c
Compare
Wirone
reviewed
Sep 16, 2022
SpacePossum
force-pushed
the
m_readonly_class_support
branch
from
b170023
to
0e97253
Compare
Wirone
requested changes
Sep 19, 2022
jrmajor
reviewed
Sep 19, 2022
SpacePossum
force-pushed
the
m_readonly_class_support
branch
2 times, most recently
from
f971b6b
to
3f4aa21
Compare
SpacePossum
force-pushed
the
m_readonly_class_support
branch
from
3f4aa21
to
fb4a429
Compare
|
@SpacePossum why did you close this PR? 🤔 |
Wirone
pushed a commit
to Wirone/PHP-CS-Fixer
that referenced
this pull request
Jan 9, 2023
These are changes initially proposed by SpacePossum in PHP-CS-Fixer#6624 but abandoned due to personal reasons. Since it's accepted by the author to use these changes, I just apply the full patch, so we can continue work.
Wirone
pushed a commit
to Wirone/PHP-CS-Fixer
that referenced
this pull request
Jan 9, 2023
These are changes initially proposed by SpacePossum in PHP-CS-Fixer#6624 but abandoned due to personal reasons. Since it's accepted by the author to use these changes, I've just applied the full patch, so we can continue work.
This was referenced Jan 9, 2023
Wirone
pushed a commit
to Wirone/PHP-CS-Fixer
that referenced
this pull request
Feb 27, 2023
These are changes initially proposed by SpacePossum in PHP-CS-Fixer#6624 but abandoned due to personal reasons. Since it's accepted by the author to use these changes, I've just applied the full patch, so we can continue work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the current the rules and code so these handle the new
readonlyclasses as added in PHP8.2.The
class_definitionrule will now also sort theclass`modifiers following: https://github.com/php-fig/per-coding-style/blob/9dc210da72285afd5ab10ab0bd34659ff5b0529f/spec.md#46-modifier-keywords