minor: Follow PSR12 ordered imports in Symfony ruleset

[VincentLanglet]

PSR12 ordered imports is set this way

PHP-CS-Fixer/src/RuleSet/Sets/PSR12Set.php

Line 50 in ff49030

'ordered_imports' => [

And Symfony extends the PSR12

PHP-CS-Fixer/src/RuleSet/Sets/SymfonySet.php

Line 27 in ff49030

'@PSR12' => true,

but then when setting the ordered import, it's true

PHP-CS-Fixer/src/RuleSet/Sets/SymfonySet.php

Line 136 in ff49030

'ordered_imports' => true,

Which means the previous config is lost, in order to have an alpha sort.

IMHO both config should be used.

• alpha sort like it always was in Symfony Ruleset
• sorting classes/functions/constantes to be PSR12

I would say it was never updated when Symfony moved from PSR2 to PSR12.

I'll fix test if this is accepted

[coveralls]

Pull Request Test Coverage Report for Build 3720836281

• 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
• 323 unchanged lines in 36 files lost coverage.
• Overall coverage increased (+0.4%) to 93.382%

---

Files with Coverage Reduction	New Missed Lines	%
src/DocBlock/DocBlock.php	1	90.91%
src/Fixer/FunctionNotation/NativeFunctionInvocationFixer.php	1	97.93%
src/Console/Application.php	2	48.94%
src/Fixer/ArrayNotation/NormalizeIndexBraceFixer.php	2	0%
src/Fixer/CastNotation/NoUnsetCastFixer.php	2	0%
src/Fixer/ClassNotation/ClassAttributesSeparationFixer.php	2	94.51%
src/Fixer/NamespaceNotation/CleanNamespaceFixer.php	2	29.41%
src/Fixer/Phpdoc/PhpdocTagCasingFixer.php	2	82.35%
src/RuleSet/RuleSetInterface.php	2	0%
src/Tokenizer/Transformers.php	2	26.09%

Totals
Change from base Build 3623594219:	0.4%
Covered Lines:	22674
Relevant Lines:	24281

---

💛 - Coveralls

[keradus]

I think we should get Sf deciders to make that call here.

[VincentLanglet]

I'll ping @nicolas-grekas then

[nicolas-grekas]

Sorry I'm not sure I fully grasp what this would change. But yes, we list "use" in alpha order. class, function then const LGTM also.

[VincentLanglet]

Sorry I'm not sure I fully grasp what this would change. But yes, we list "use" in alpha order. class, function then const LGTM also.

Cf https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/doc/rules/import/ordered_imports.rst#rule-sets, Symfony use ordered_imports with default config, which is

['sort_algorithm' => 'alpha']

so it's loosing the PSR12 part

'imports_order' => ['class', 'function', 'const']

Which means that even if Symfony surely wants to respect the PSR12, the SymfonyRuleset doesn't fix this automatically.

When Symfony override the rule to set the sort algorithm to alpha, we need to repeat the import order too.

[keradus]

looks like there is an alignment ;)

[VincentLanglet]

I fixed the tests @keradus

Btw, all ruleset will use at least 'imports_order' => ['class', 'function', 'const'] now.

It might be interesting to change the default value of the rule from

['sort_algorithm' => 'alpha']

to

['imports_order' => ['class', 'function', 'const'], 'sort_algorithm' => 'alpha']

in next major then. Does it require a comment somewhere ?

[julienfalque]

Does it require a comment somewhere ?

We use to add TODOs for that, e.g. // @TODO set to ['class', 'function', 'const'] on 4.0 next to the setDefault() call in OrderedImportsFixer.

[VincentLanglet]

Thanks @julienfalque, it's done

[julienfalque]

Thank you @VincentLanglet.