Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: make OrderedInterfacesFixer non-risky #6722

Merged
merged 1 commit into from Jan 2, 2023
Merged

feature: make OrderedInterfacesFixer non-risky #6722

merged 1 commit into from Jan 2, 2023

Conversation

kubawerlos
Copy link
Contributor

The reason it was marked risky is because "Class (class name here) cannot implement previously implemented interface (interface name here)" which is not an error since PHP 7.4.

For code:

<?php

interface A {}
interface B extends A {}

class C1 implements A, B {}
class C2 implements B, A {}

it is correct for PHP 7.4.0 - 7.4.33, 8.0.0 - 8.0.26, 8.1.0 - 8.1.13, 8.2.0: https://3v4l.org/sRH9L

@coveralls
Copy link

coveralls commented Dec 22, 2022

Pull Request Test Coverage Report for Build 3824837819

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 93.404%

Files with Coverage Reduction New Missed Lines %
src/PharChecker.php 1 85.71%
Totals Coverage Status
Change from base Build 3722532501: 0.02%
Covered Lines: 22673
Relevant Lines: 24274

💛 - Coveralls

@keradus keradus added the RTM Ready To Merge label Dec 27, 2022
@keradus
Copy link
Member

keradus commented Dec 27, 2022

PRLint no longer triggers, @kubawerlos ?

@kubawerlos
Copy link
Contributor Author

@keradus can it be related to changing the organisation of the repository?

@keradus keradus closed this Jan 2, 2023
@keradus keradus reopened this Jan 2, 2023
@kubawerlos kubawerlos changed the title Make OrderedInterfacesFixer non-risky feature: make OrderedInterfacesFixer non-risky Jan 2, 2023
@kubawerlos kubawerlos merged commit f5726f5 into PHP-CS-Fixer:master Jan 2, 2023
@kubawerlos kubawerlos deleted the make_OrderedInterfacesFixer_non_risky branch January 2, 2023 20:27
@keradus keradus removed the RTM Ready To Merge label Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants