Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: PHP8.2 - test for DNF types #6802

Closed
wants to merge 3 commits into from
Closed

minor: PHP8.2 - test for DNF types #6802

wants to merge 3 commits into from

Conversation

keradus
Copy link
Member

@keradus keradus commented Feb 28, 2023

No description provided.

@keradus
Copy link
Member Author

keradus commented Feb 28, 2023

@SpacePossum , @Wirone , @kubawerlos - maybe any of you can help to make it pass?

@coveralls
Copy link

coveralls commented Feb 28, 2023 •
edited

Pull Request Test Coverage Report for Build 4317049488

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.906%
Totals Coverage Status
Change from base Build 4297719317: 0.0%
Covered Lines: 22735
Relevant Lines: 24471
💛 - Coveralls

@Wirone
Copy link
Member

Wirone commented Mar 1, 2023

@keradus there was #6608 issue and #6629 PR, but these were closed just like readonly support. If @SpacePossum agrees, I can resurrect it too and continue the work.

@SpacePossum
Copy link
Contributor

I haven't checked anything for a long time so I cannot say what the state is of #6629
If you are up for it, please have a look @Wirone :) but also, feel free to start from scratch, what ever works best for you 👍

@keradus keradus added the topic/PHP8.2 Related to features available in PHP 8.2+ label Mar 1, 2023
@keradus
Copy link
Member Author

keradus commented Mar 1, 2023

Thanks for picking it up!
I believe it's the last topic to claim 8.2 support

@kubawerlos kubawerlos changed the title PHP8.2: test for DNF types minor: PHP8.2: test for DNF types Mar 2, 2023
@kubawerlos kubawerlos changed the title minor: PHP8.2: test for DNF types minor: PHP8.2 - test for DNF types Mar 2, 2023
@kubawerlos kubawerlos mentioned this pull request Mar 2, 2023
Merged
@keradus keradus closed this Mar 11, 2023
@keradus keradus removed the topic/PHP8.2 Related to features available in PHP 8.2+ label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubawerlos kubawerlos kubawerlos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@keradus @coveralls @Wirone @SpacePossum @kubawerlos