DX: Include self_static_accessor fixer in PhpCsFixer set #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4612059529
馃挍 - Coveralls |
|
Overall that's the goal, but also that's generating conflicts. should we limit amount of PRs first? |
I don't see it happen soon enough 馃槄. I believe it would be better to apply it and then it's really easy to rebase PRs end resolve conflicts (because Fixer will fix it anyway, regardless of how conflict is resolved). Personally I am not afraid of invasive changes and I even could help with rebasing things, if I had enough project role to do it 馃槈. |
|
I remember we had this discussion 2 years ago with the same plan - to lower the number of open PRs. Let's fix the conflict and merge it, any conflicts it will introduce would be easy to resolve. |
kubawerlos
approved these changes
Apr 28, 2023
Wirone
force-pushed
the
codito/no-redundant-static-call-within-final-method
branch
from
352c3cb
to
f0792f8
Compare
|
Thank you @Wirone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStorm underlines all of these
static::calls in tests and I thought it would be good to include this fixer in thePhpCsFixerruleset to keep the code clean from such redundant usage 馃檪. Let me know what you think.