minor: PHP8.3 - Typed class constants - handle nullable by transformer #7009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacePossum
force-pushed
the
main/feature_php83_typed_consts_transformer_fix
branch
from
8a5e732
to
094662d
Compare
Wirone
approved these changes
May 29, 2023
|
Thank you @SpacePossum 👍🏼 |
niklam
pushed a commit
to niklam/PHP-CS-Fixer
that referenced
this pull request
Jun 19, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP8.3 introduces typed classy constants:
https://wiki.php.net/rfc/typed_class_constants
To support/handling these in the code I propose to change the
nullable?native token into same custom tokenCT::T_NULLABLE_TYPEas is done for the other nullable-typehints currentlypart of #6999