Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: SelfStaticAccessorFixer improvements for enums #7026

Merged
merged 1 commit into from
Jun 6, 2023
Merged

minor: SelfStaticAccessorFixer improvements for enums #7026

merged 1 commit into from
Jun 6, 2023

Conversation

SpacePossum
Copy link
Contributor

@SpacePossum SpacePossum commented Jun 5, 2023 •
edited

closes #7005

@Wirone
Copy link
Member

Wirone commented Jun 5, 2023

@SpacePossum just merged #7024 which solved the same bug 🙈. But your test cases looks more complex, maybe you can rebase this PR and we can include them too?

@SpacePossum SpacePossum force-pushed the bug/SelfStaticAccessorFixer-enum branch from a50b399 to e1f5dfd Compare June 5, 2023 15:25
@SpacePossum
Copy link
Contributor Author

sure thing, better to have two fixes than none :D thanks @paulbalandan 👍
rebased! I left the tweak in to not get the class modifiers for an enum as we don't need those

@SpacePossum SpacePossum force-pushed the bug/SelfStaticAccessorFixer-enum branch from e1f5dfd to c8aa623 Compare June 5, 2023 17:02
Wirone
Wirone approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One doubt, not a blocker hence 👍.

tests/Fixer/ClassNotation/SelfStaticAccessorFixerTest.php Show resolved Hide resolved
@Wirone Wirone changed the title minor: SelfStaticAccessorFixer - Fix enum minor: SelfStaticAccessorFixer improvements for enums Jun 6, 2023
@Wirone Wirone merged commit 137667d into PHP-CS-Fixer:master Jun 6, 2023
14 checks passed
@Wirone
Copy link
Member

Wirone commented Jun 6, 2023

Thanks @SpacePossum 🍻

@SpacePossum SpacePossum deleted the bug/SelfStaticAccessorFixer-enum branch June 6, 2023 17:15
niklam pushed a commit to niklam/PHP-CS-Fixer that referenced this pull request Jun 19, 2023
@SpacePossum @niklam
minor: SelfStaticAccessorFixer improvements for enums (PHP-CS-Fixer…
30fe600 
…#7026)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SelfStaticAccessorFixer - Does not fix enums
2 participants
@SpacePossum @Wirone