DX: Use Utils::naturalLanguageJoin() in implode calls
#7032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
use-utils-natural-language-join
branch
from
6e5939e
to
29a9252
Compare
Wirone
requested changes
Jun 6, 2023
paulbalandan
force-pushed
the
use-utils-natural-language-join
branch
from
29a9252
to
32b2d32
Compare
paulbalandan
force-pushed
the
use-utils-natural-language-join
branch
from
32b2d32
to
62c9fa1
Compare
Wirone
approved these changes
Jun 7, 2023
|
Thanks @paulbalandan 🍻 |
niklam
pushed a commit
to niklam/PHP-CS-Fixer
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7022
Changes mainly done on documentation generation and exception messages.