Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: PhpdocToCommentFixer support for enum cases #7040

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

Wirone
Copy link
Member

@Wirone Wirone commented Jun 8, 2023

Fixes #7030
Fixes #6204

@Wirone Wirone self-assigned this Jun 8, 2023
@Wirone Wirone requested a review from kubawerlos June 8, 2023 00:49
@Wirone Wirone force-pushed the codito/7030-phpdoc-over-enum-case branch from 38676bd to 39fb1f7 Compare June 8, 2023 00:52
Copy link
Contributor

@kubawerlos kubawerlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have this merged before to prevent regression.

@paulbalandan
Copy link
Contributor

I think this should also fix #6204

@Wirone Wirone force-pushed the codito/7030-phpdoc-over-enum-case branch 2 times, most recently from 70fdaab to d85353c Compare June 8, 2023 10:01
@Wirone Wirone requested a review from kubawerlos June 8, 2023 11:06
@Wirone Wirone force-pushed the codito/7030-phpdoc-over-enum-case branch from d85353c to 9ef7dae Compare June 12, 2023 22:55
@Wirone Wirone force-pushed the codito/7030-phpdoc-over-enum-case branch from 9ef7dae to 95fed43 Compare June 12, 2023 22:57
@Wirone
Copy link
Member Author

Wirone commented Jun 12, 2023

Github Actions work weird right now, I force-pushed rebased branch 2 times and both workflows cancelled 1 of the jobs (and can't be retried). I'll try again tomorrow.

@Wirone Wirone requested a review from kubawerlos June 12, 2023 23:07
@Wirone Wirone merged commit 7b7f77f into PHP-CS-Fixer:master Jun 13, 2023
14 checks passed
@Wirone Wirone deleted the codito/7030-phpdoc-over-enum-case branch June 13, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants