-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: PhpdocToCommentFixer
support for enum cases
#7040
Merged
Wirone
merged 5 commits into
PHP-CS-Fixer:master
from
Wirone:codito/7030-phpdoc-over-enum-case
Jun 13, 2023
Merged
bug: PhpdocToCommentFixer
support for enum cases
#7040
Wirone
merged 5 commits into
PHP-CS-Fixer:master
from
Wirone:codito/7030-phpdoc-over-enum-case
Jun 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wirone
force-pushed
the
codito/7030-phpdoc-over-enum-case
branch
from
June 8, 2023 00:52
38676bd
to
39fb1f7
Compare
kubawerlos
requested changes
Jun 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have this merged before to prevent regression.
I think this should also fix #6204 |
Wirone
force-pushed
the
codito/7030-phpdoc-over-enum-case
branch
2 times, most recently
from
June 8, 2023 10:01
70fdaab
to
d85353c
Compare
kubawerlos
reviewed
Jun 8, 2023
Wirone
force-pushed
the
codito/7030-phpdoc-over-enum-case
branch
from
June 12, 2023 22:55
d85353c
to
9ef7dae
Compare
Wirone
force-pushed
the
codito/7030-phpdoc-over-enum-case
branch
from
June 12, 2023 22:57
9ef7dae
to
95fed43
Compare
Github Actions work weird right now, I force-pushed rebased branch 2 times and both workflows cancelled 1 of the jobs (and can't be retried). I'll try again tomorrow. |
kubawerlos
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7030
Fixes #6204