feat: Rename CurlyBraceTransformer to BraceTransformer

[localheinz]

This pull request

• renames the (internal) CurlyBraceTransformer to BraceTransformer

Related to #5915 (comment).
Follows #7328 (comment).

💁‍♂️ Looks like it's not used anywhere, maybe we should remove or use it where it makes sense?

[Wirone]

Looks like it's not used anywhere, maybe we should remove or use it where it makes sense?

All transformers are magically registered in PhpCsFixer\Tokenizer\Transformers::registerBuiltInTransformers() and used effectively in PhpCsFixer\Tokenizer\Tokens::applyTransformers() during tokenisation, so we can't remove it 😉.

PS. I would wait with such refactorings until we set up final vision in #5915 (especially here).

[coveralls]

coverage: 94.661%. remained the same when pulling 85f8672 on localheinz:fix/curly-brace-transformer into f1abe95 on PHP-CS-Fixer:master.

[localheinz]

@Wirone

Not entirely sure about this change, maybe we would need to rename

PHP-CS-Fixer/src/Tokenizer/Transformer/ArrayTypehintTransformer.php

Line 29 in 7e1ab20

final class ArrayTypehintTransformer extends AbstractTransformer

as well (see #7338)?

The transformers refer to PHP tokens, and the constants sometimes use inconsistent naming, too.

[Wirone]

The transformers refer to PHP tokens, and the constants sometimes use inconsistent naming, too.

@localheinz I've already warned you about that in your first PR that touched transformers 😉. Some fixers can be renamed safely IMHO, but we really need some decisions in #5915.

[keradus]

If I miss sth please describe.
As long as we rename internal class, but not exposed CT:: values, we are good to rename things.

If we would rename CT::*, we can break BC.

(and agree that removing it would break our code)

[localheinz]

Thank you, @keradus and @Wirone!