feat(PER-CS2.0): The fn keyword MUST NOT be succeeded by a space. #7355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacePossum
changed the title
SpacePossum
force-pushed
the
PER_FN_follow
branch
from
357b4a3
to
8b791a0
Compare
keradus
reviewed
Oct 9, 2023
Comment on lines
+39
to
+41
| 'closure_fn_spacing' => 'none', | ||
| 'closure_function_spacing' => 'one', | ||
| 'trailing_comma_single_line' => false, |
There was a problem hiding this comment.
If I understand right, only closure_fn_spacing is non-default here.
I suggest to explicitly configure closure_fn_spacing only in that case, and make a TODO for fixer to change default for closure_fn_spacing in next major
|
I believe it's a duplicate of #6970 🙂. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ see https://github.com/php-fig/per-coding-style/blob/2.0.0/spec.md
after #7247 can be updated