Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: early compatibility checks with Symfony 7 #7431

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

keradus
Copy link
Member

@keradus keradus commented Nov 12, 2023

No description provided.

@keradus keradus force-pushed the symfony_7 branch 4 times, most recently from d993434 to 9e714c6 Compare November 12, 2023 21:10
@coveralls
Copy link

coveralls commented Nov 12, 2023

Coverage Status

coverage: 94.784%. remained the same
when pulling 4c443f8 on keradus:symfony_7
into 1d612d2 on PHP-CS-Fixer:master.

@keradus keradus changed the title . chore: early compatibility checks with Symfony 7 Nov 12, 2023
@keradus keradus marked this pull request as ready for review November 12, 2023 21:32
@keradus keradus enabled auto-merge (squash) November 13, 2023 13:57
@keradus keradus changed the title chore: early compatibility checks with Symfony 7 CI: early compatibility checks with Symfony 7 Nov 13, 2023
@keradus
Copy link
Member Author

keradus commented Nov 20, 2023

🤷🏻

@keradus keradus merged commit 8ad4961 into PHP-CS-Fixer:master Nov 20, 2023
24 checks passed
@keradus keradus deleted the symfony_7 branch November 20, 2023 12:41
@VincentLanglet
Copy link
Contributor

Since your Ci is running successfully with SF 7, would it be ok to add || ^7.0 in the composer.json in order to allow us trying SF 7 on our CI too ? Thanks 🙏

I can do the PR if accepted

cc @Wirone

@keradus
Copy link
Member Author

keradus commented Nov 22, 2023

from semver perspective, 7@beta can still break BC before releasing 7@stable.
is core Symfony team confirming to not introduce any more BC breaks for v7 line? if not, I prefer to wait for stable release.

@VincentLanglet
Copy link
Contributor

VincentLanglet commented Nov 22, 2023

is core Symfony team confirming to not introduce any more BC breaks for v7 line? if not, I prefer to wait for stable release.

No idea, I see multiple fixes but I can't guarantee about BC-break indeed.
Maybe @nicolas-grekas can provide an answer for this (?)

@nicolas-grekas
Copy link

RC1 means no BC breaks anymore so it's safe to allow 7 IMHO

@VincentLanglet
Copy link
Contributor

Thanks ; I opened #7453 @keradus then.

@keradus
Copy link
Member Author

keradus commented Nov 22, 2023

ah, it's already RC? nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants