-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate Token::isKeyCaseSensitive #7599
chore: deprecate Token::isKeyCaseSensitive #7599
Conversation
Thank you @keradus |
@@ -216,6 +218,11 @@ public function equalsAny(array $others, bool $caseSensitive = true): bool | |||
*/ | |||
public static function isKeyCaseSensitive($caseSensitive, int $key): bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the method itself wasn't marked as @deprecated
? It's better to have visual feedback when writing code instead of getting deprecation warning or tests failed when running it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.