-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PhpdocToParamTypeFixerTest - support for arrow functions #7647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
force-pushed
the
phpdoc_to_param-_fn
branch
from
January 2, 2024 23:35
1eac38b
to
8935129
Compare
julienfalque
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add similar cases to no_superfluous_phpdoc_tags
?
good idea, I park it here: #7666 |
Wirone
reviewed
Jan 3, 2024
Comment on lines
+482
to
+505
yield 'support for arrow function' => [ | ||
'<?php | ||
Utils::stableSort( | ||
$elements, | ||
/** | ||
* @param int $a | ||
* | ||
* @return array | ||
*/ | ||
static fn(int $a) => [$a], | ||
fn($a, $b) => 1, | ||
);', | ||
'<?php | ||
Utils::stableSort( | ||
$elements, | ||
/** | ||
* @param int $a | ||
* | ||
* @return array | ||
*/ | ||
static fn($a) => [$a], | ||
fn($a, $b) => 1, | ||
);', | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it should be:
Suggested change
yield 'support for arrow function' => [ | |
'<?php | |
Utils::stableSort( | |
$elements, | |
/** | |
* @param int $a | |
* | |
* @return array | |
*/ | |
static fn(int $a) => [$a], | |
fn($a, $b) => 1, | |
);', | |
'<?php | |
Utils::stableSort( | |
$elements, | |
/** | |
* @param int $a | |
* | |
* @return array | |
*/ | |
static fn($a) => [$a], | |
fn($a, $b) => 1, | |
);', | |
]; | |
yield 'arrow function' => [ | |
'<?php /** @param int $a */ fn(int $a) => 1;', | |
'<?php /** @param int $a */ fn($a) => 1;', | |
]; | |
yield 'support for arrow function' => [ | |
'<?php | |
Utils::stableSort( | |
$elements, | |
/** | |
* @param int $a | |
*/ | |
static fn(int $a) => [$a], | |
fn($a, $b) => 1, | |
);', | |
'<?php | |
Utils::stableSort( | |
$elements, | |
/** | |
* @param int $a | |
*/ | |
static fn($a) => [$a], | |
fn($a, $b) => 1, | |
);', | |
]; |
- basic arrow function test case
- complex arrow function test case
@return
annotations are superfluous here, since this fixer handles only@param
But I was too late 😅.
danog
pushed a commit
to zoonru/PHP-CS-Fixer
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.