fix: FQCN parse phpdoc using full grammar regex #7649
Conversation
mvorisek
force-pushed
the
fqcn_parse_phpdoc_using_regex
branch
2 times, most recently
from
c2a28ab
to
2b3e237
Compare
mvorisek
force-pushed
the
fqcn_parse_phpdoc_using_regex
branch
from
6f4a670
to
659c19e
Compare
mvorisek
force-pushed
the
fqcn_parse_phpdoc_using_regex
branch
from
792e224
to
b87fabc
Compare
mvorisek
force-pushed
the
fqcn_parse_phpdoc_using_regex
branch
from
cd5d1fa
to
bbd8bc9
Compare
mvorisek
force-pushed
the
fqcn_parse_phpdoc_using_regex
branch
2 times, most recently
from
5844908
to
b21f564
Compare
|
@mvorisek this PR does not provide support for multiline phpDoc types, right? Is it actually possible to handle them with the regex approach, since |
2x right |
mvorisek
force-pushed
the
fqcn_parse_phpdoc_using_regex
branch
from
999bff8
to
df78046
Compare
| @@ -586,7 +586,7 @@ function validate(): void {} | |||
| */ | |||
| function validate(): void {} | |||
| ', | |||
| ['import_symbols' => true], | |||
| ['import_symbols' => true, 'phpdoc_tags' => ['link']], | |||
There was a problem hiding this comment.
i would be wondering why link is not there by default, but probably other discussion :D
| yield 'PHPDoc with generics must not crash' => [ | ||
| '<?php | ||
|
|
||
| /** | ||
| * @param \Iterator<mixed, \SplFileInfo> $iter | ||
| */ | ||
| function foo($iter) {}', | ||
| ]; | ||
|
|
There was a problem hiding this comment.
side note:
with recently introduced "test class is contract", while adding support for generics, you would need to put it behind rule option, as otherwise it would change contract behaviour.
|
@mvorisek if great work of yours are not getting attention for longer period, please do not hesitate to poke on us, but you may give us more time than one day before pushing 😅 |
This PR fixes all issues with partly parsed phpdoc type.
in short, it matches the type correctly using full grammar regex and then the parsed match is tested if it is a simple type: