Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle FQCN properly with leading_backslash_in_global_namespace option enabled #7654

Merged
merged 4 commits into from
Jan 3, 2024
Merged

fix: Handle FQCN properly with leading_backslash_in_global_namespace option enabled #7654

merged 4 commits into from
Jan 3, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jan 1, 2024 •
edited

@mvorisek mvorisek mentioned this pull request Jan 1, 2024
Merged
@mvorisek mvorisek force-pushed the fqcn_global_rm_leading_backslash branch 4 times, most recently from 9605d56 to 6453796 Compare January 1, 2024 22:35
@mvorisek mvorisek mentioned this pull request Jan 2, 2024
Merged
@mvorisek mvorisek force-pushed the fqcn_global_rm_leading_backslash branch from 6453796 to 5bfc669 Compare January 3, 2024 10:54
@mvorisek mvorisek marked this pull request as ready for review January 3, 2024 11:02
@mvorisek
Copy link
Contributor Author

mvorisek commented Jan 3, 2024

@Wirone would you find a moment for review this PR as well - I need it to finish other PRs :)

Wirone
Wirone reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@Wirone Wirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand the changes, the leading_backslash_in_global_namespace option was preventing fixer from removing leading \, but it was not ensuring it's added when missing? Looks good in general, one minor improvement requested.

src/Fixer/Import/FullyQualifiedStrictTypesFixer.php Outdated Show resolved Hide resolved
@Wirone Wirone added the topic/fqcn Fully Qualified Class Name usage and conversions label Jan 3, 2024
@mvorisek mvorisek requested a review from Wirone January 3, 2024 16:06
@Wirone Wirone changed the title fix: FQCN /w leading_backslash_in_global_namespace option fix: Handle FQCN properly with leading_backslash_in_global_namespace option enabled Jan 3, 2024
@Wirone Wirone force-pushed the fqcn_global_rm_leading_backslash branch from ade30d8 to ff823bd Compare January 3, 2024 16:27
@Wirone Wirone enabled auto-merge (squash) January 3, 2024 16:27
@Wirone Wirone merged commit 0061223 into PHP-CS-Fixer:master Jan 3, 2024
25 checks passed
@mvorisek mvorisek deleted the fqcn_global_rm_leading_backslash branch January 3, 2024 16:38
@yubiuser yubiuser mentioned this pull request Jan 6, 2024
Closed
danog pushed a commit to zoonru/PHP-CS-Fixer that referenced this pull request Feb 2, 2024
@mvorisek @Wirone @danog
fix: Handle FQCN properly with `leading_backslash_in_global_namespace…
62ee0f1 
…` option enabled (PHP-CS-Fixer#7654)

Co-authored-by: Greg Korba <greg@codito.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wirone Wirone Wirone approved these changes

Assignees
No one assigned
Labels
topic/fqcn Fully Qualified Class Name usage and conversions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvorisek @Wirone