fix: Support shebang in fixers operating on PHP opening tag #7687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
Jan 7, 2024
mvorisek
force-pushed
the
fix_declare_7634
branch
4 times, most recently
from
36f0af3
to
d453856
Compare
Wirone
reviewed
Jan 8, 2024
mvorisek
force-pushed
the
fix_declare_7634
branch
from
4040754
to
0ec249e
Compare
|
I relanded the original behaviour. I do not however see any benefit by considering T_OPEN_TAG_WITH_ECHO as monotonic (one script file) as most of the fixers does not support it. Maybe they miss the support. IDK. see last commit - it makes things ugly and inconsistent (to match original design), but you decide, I would revert the last commit |
mvorisek
force-pushed
the
fix_declare_7634
branch
from
b925b40
to
0254e4b
Compare
Wirone
requested changes
Jan 10, 2024
mvorisek
force-pushed
the
fix_declare_7634
branch
from
0254e4b
to
874b011
Compare
|
@Wirone is there any feedback left? |
|
@mvorisek I don't know, I did not have time to look at it yet 🤷♂️. |
mvorisek
force-pushed
the
fix_declare_7634
branch
from
35fe0bd
to
c60d118
Compare
|
Kindly ping @Wirone, the current master/release is broken. |
mvorisek
force-pushed
the
fix_declare_7634
branch
from
f0e8f5f
to
4acbce1
Compare
mvorisek
changed the title
declare_strict_types must work with shebang
Wirone
changed the title
Wirone
approved these changes
Jan 18, 2024
julienfalque
approved these changes
Jan 18, 2024
Wirone
force-pushed
the
fix_declare_7634
branch
from
361d88f
to
7dca284
Compare
|
Thanks @mvorisek 🍻 |
|
Thank you @mvorisek 🎉 |
danog
pushed a commit
to zoonru/PHP-CS-Fixer
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7634 (and #7681 duplicate)