fix: NoSpaceAroundDoubleColonFixer must run before MethodChainingIndentationFixer

[mho22]

Fixes #7699.

[mho22]

@Wirone Considering the minor changes that were added, the static code analysis check seems a bit peculiar.

[Wirone]

@mho22 hard to tell, does it work correctly when you execute composer qa locally?

[mho22]

@Wirone No, indeed.

I get this error

PHP-CS-Fixer [master] composer qa
> Composer\Config::disableProcessTimeout
> ./dev-tools/check_file_permissions.sh
"php-cs-fixer" is executable
No wrong permissions detected.
> ./dev-tools/check_trailing_spaces.sh
Trailing whitespaces detected:
tests/Fixer/Phpdoc/PhpdocAlignFixerTest.php:697:     * @param mixed    $bar    Description word_with_ą
tests/Fixer/Phpdoc/PhpdocAlignFixerTest.php:704:     * @SuppressWarnings(PHPMD.UnusedLocalVariable) word_with_ą
tests/Fixer/Phpdoc/PhpdocAlignFixerTest.php:714:     * @param mixed $bar Description word_with_ą
tests/Fixer/Phpdoc/PhpdocAlignFixerTest.php:721:     *   @SuppressWarnings(PHPMD.UnusedLocalVariable) word_with_ą
tests/Fixer/Phpdoc/PhpdocTrimFixerTest.php:54: * @return int количество деактивированных
tests/Fixer/Phpdoc/PhpdocTrimFixerTest.php:66: * Test à
tests/Fixer/Whitespace/NoTrailingWhitespaceFixerTest.php:95:garçon, si bien qu'il ne savait s'il fallait garder sa casquette à
Script ./dev-tools/check_trailing_spaces.sh handling the self-check event returned with error code 3
Script @self-check was called via quality-assurance
Script @quality-assurance was called via qa

I managed to bypass the error using composer test:integration.

I have the same error when cloning the repo [ with those steps ] :

git clone https://github.com/PHP-CS-Fixer/PHP-CS-Fixer.git

composer install

composer qa

[Wirone]

There are many Composer scripts that are building blocks for qa. Looking at the pipeline here, you should locally look at composer auto-review and composer test. In general, you should be able to pass the whole QA suite locally to be able to effectively work with Fixer.

[mho22]

@Wirone I think the CI could possibly be broken by some unrelated change - as indicated in another recent PR comment ? : #7724 (comment)

[coveralls]

coverage: 94.805%. remained the same
when pulling d252f76 on mho22:7699-fix-priority-no-space-around-double-colon
into 6d57705 on PHP-CS-Fixer:master.

[mho22]

@Wirone I've finally passed all the checks. Thanks for following up.

[Wirone]

FYI: before this PR the result of using those 2 rules depended on the way how Fixer was executed - you could have 2 different outcomes depending on the order of the rules:

After this PR it does not matter in which order rules are added to the final ruleset, their priorities determine the actual order.

[Wirone]

Thank you @mho22 🍻!