New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow PHPUnit 11 #7808
feat: allow PHPUnit 11 #7808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHPUnit 11 is not installed in any job right now, so there is no confirmation it actually works.
Thanks for pointing this out. I will Change the description. |
both have failing CI, which has to be addressed first. |
actually they are failing because Fixer version is not locked (I'm OK with that for those repos) and is not related to proposed change on it's own - I will solve that independently. still, for this PR, we shall see a job which uses PHPUnit 11 to prove it works, as Kuba mentioned, before merging it. I hope with releases of new version of our constraints, we will see it now |
There is more blocking. |
@Chris53897 you can just use |
I already did ;)
|
I'm working on facile-it/paraunit#230 to allow PHPUnit 11 fully, the first release wasn't complete. |
I just released 2.3.1, with the needed fixes: https://github.com/facile-it/paraunit/releases/tag/2.3.1 |
Thank you @Jean85 🍻! |
Code coverage is failing since PHPUnit 11 requires a different format for the configuration: Splitting the config in two may be the only possible course of action. |
@Chris53897 thank you for taking your time, but @kubawerlos prepared this support with green pipeline in #7824, so it was merged before yours. Keep going with contributions 🙂. |
@Wirone This is fine. Thanks @kubawerlos |
Blocked by