Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow PHPUnit 11 #7808

Closed
wants to merge 5 commits into from
Closed

feat: allow PHPUnit 11 #7808

wants to merge 5 commits into from

Conversation

Chris53897
Copy link

@Chris53897 Chris53897 commented Feb 3, 2024

@coveralls
Copy link

coveralls commented Feb 3, 2024

Coverage Status

coverage: 94.759%. remained the same
when pulling 27883dd on Chris53897:feature/add-support-for-phpunit-11
into ee8a4ef on PHP-CS-Fixer:master.

@Chris53897 Chris53897 changed the title chore: add support for PHPUnit 11 feat: add support for PHPUnit 11 Feb 3, 2024
Copy link
Contributor

@kubawerlos kubawerlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPUnit 11 is not installed in any job right now, so there is no confirmation it actually works.

@Wirone Wirone linked an issue Feb 3, 2024 that may be closed by this pull request
@Chris53897
Copy link
Author

Thanks for pointing this out. I will Change the description.
In that case, please have a look at the blocking PRs.

@kubawerlos
Copy link
Contributor

please have a look at the blocking PRs.

both have failing CI, which has to be addressed first.

@keradus
Copy link
Member

keradus commented Feb 4, 2024

actually they are failing because Fixer version is not locked (I'm OK with that for those repos) and is not related to proposed change on it's own - I will solve that independently.
( PHP-CS-Fixer/phpunit-constraint-isidenticalstring#19 + PHP-CS-Fixer/phpunit-constraint-xmlmatchesxsd#23 )

still, for this PR, we shall see a job which uses PHPUnit 11 to prove it works, as Kuba mentioned, before merging it.

I hope with releases of new version of our constraints, we will see it now

@Chris53897
Copy link
Author

@Wirone
Copy link
Member

Wirone commented Feb 4, 2024

@Chris53897 you can just use composer why-not phpunit/phpunit ^11 🙂. I was going to check it when I have time, but you can do it yourself too.

@Chris53897
Copy link
Author

Chris53897 commented Feb 4, 2024

I already did ;)

composer why-not "phpunit/phpunit" 11.0.1

friendsofphp/php-cs-fixer dev-master does not require phpunit/php-code-coverage (but 10.1.11 is installed) 
phpunit/phpunit           11.0.1     requires         phpunit/php-file-iterator (^5.0)                     
friendsofphp/php-cs-fixer dev-master does not require phpunit/php-file-iterator (but 4.1.0 is installed)   
phpunit/phpunit           11.0.1     requires         phpunit/php-invoker (^5.0)                           
friendsofphp/php-cs-fixer dev-master does not require phpunit/php-invoker (but 4.0.0 is installed)         
phpunit/phpunit           11.0.1     requires         phpunit/php-text-template (^4.0)                     
friendsofphp/php-cs-fixer dev-master does not require phpunit/php-text-template (but 3.0.1 is installed)   
phpunit/phpunit           11.0.1     requires         phpunit/php-timer (^7.0)                             
friendsofphp/php-cs-fixer dev-master does not require phpunit/php-timer (but 6.0.0 is installed)           
phpunit/phpunit           11.0.1     requires         sebastian/cli-parser (^3.0)                          
friendsofphp/php-cs-fixer dev-master does not require sebastian/cli-parser (but 2.0.0 is installed)        
phpunit/phpunit           11.0.1     requires         sebastian/code-unit (^3.0)                           
friendsofphp/php-cs-fixer dev-master does not require sebastian/code-unit (but 2.0.0 is installed)         
phpunit/phpunit           11.0.1     requires         sebastian/comparator (^6.0)                          
friendsofphp/php-cs-fixer dev-master does not require sebastian/comparator (but 5.0.1 is installed)        
phpunit/phpunit           11.0.1     requires         sebastian/diff (^6.0)                                
friendsofphp/php-cs-fixer dev-master does not require sebastian/diff (but 5.1.0 is installed)              
phpunit/phpunit           11.0.1     requires         sebastian/environment (^7.0)                         
friendsofphp/php-cs-fixer dev-master does not require sebastian/environment (but 6.0.1 is installed)       
phpunit/phpunit           11.0.1     requires         sebastian/exporter (^6.0)                            
friendsofphp/php-cs-fixer dev-master does not require sebastian/exporter (but 5.1.1 is installed)          
phpunit/phpunit           11.0.1     requires         sebastian/global-state (^7.0)                        
friendsofphp/php-cs-fixer dev-master does not require sebastian/global-state (but 6.0.1 is installed)      
phpunit/phpunit           11.0.1     requires         sebastian/object-enumerator (^6.0)                   
friendsofphp/php-cs-fixer dev-master does not require sebastian/object-enumerator (but 5.0.0 is installed) 
phpunit/phpunit           11.0.1     requires         sebastian/type (^5.0)                                
friendsofphp/php-cs-fixer dev-master does not require sebastian/type (but 4.0.0 is installed)              
phpunit/phpunit           11.0.1     requires         sebastian/version (^5.0)                             
friendsofphp/php-cs-fixer dev-master does not require sebastian/version (but 4.0.1 is installed)           

@keradus keradus changed the title feat: add support for PHPUnit 11 feat: allow PHPUnit 11 Feb 4, 2024
@Jean85
Copy link
Contributor

Jean85 commented Feb 4, 2024

I'm working on facile-it/paraunit#230 to allow PHPUnit 11 fully, the first release wasn't complete.
It should work now, but I'm having some issues in my CI, and this PR was one of the blockers 😄 I did a workaround to avoid the circular dependency, now I just have to fix a small issue in a test.

@Jean85
Copy link
Contributor

Jean85 commented Feb 6, 2024

I just released 2.3.1, with the needed fixes: https://github.com/facile-it/paraunit/releases/tag/2.3.1

@Wirone
Copy link
Member

Wirone commented Feb 6, 2024

Thank you @Jean85 🍻!

@Jean85
Copy link
Contributor

Jean85 commented Feb 6, 2024

Code coverage is failing since PHPUnit 11 requires a different format for the configuration: coverage nodes have to be renamed as source. This change is backward compatible and available since PHPUnit 10.1, so you may have issues with PHPUnit 10.0 and lower, and in turn for PHP 8.0 and lower.

Splitting the config in two may be the only possible course of action.

@Wirone
Copy link
Member

Wirone commented Feb 6, 2024

@Chris53897 thank you for taking your time, but @kubawerlos prepared this support with green pipeline in #7824, so it was merged before yours. Keep going with contributions 🙂.

@Wirone Wirone closed this Feb 6, 2024
@Chris53897 Chris53897 deleted the feature/add-support-for-phpunit-11 branch February 7, 2024 07:39
@Chris53897
Copy link
Author

@Wirone This is fine. Thanks @kubawerlos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with phpunit 11
8 participants