Merge pull request #460 from syhol/patch-1

Use variadic args in constructor
PHP-DI · Mar 16, 2017 · 5211b8e · 5211b8e
2 parents 1b1cb76 + 738527a
commit 5211b8e
Showing 1 changed file with 1 addition and 21 deletions.
diff --git a/src/DI/Definition/Resolver/ObjectCreator.php b/src/DI/Definition/Resolver/ObjectCreator.php
@@ -146,27 +146,7 @@ private function createInstance(ObjectDefinition $definition, array $parameters)
                 $parameters
             );
 
-            // Optimization trick
-            switch (count($args)) {
-                case 0:
-                    $object = new $classname;
-                    break;
-                case 1:
-                    $object = new $classname($args[0]);
-                    break;
-                case 2:
-                    $object = new $classname($args[0], $args[1]);
-                    break;
-                case 3:
-                    $object = new $classname($args[0], $args[1], $args[2]);
-                    break;
-                case 4:
-                    $object = new $classname($args[0], $args[1], $args[2], $args[3]);
-                    break;
-                default:
-                    $object = $classReflection->newInstanceArgs($args);
-                    break;
-            }
+            $object = new $classname(...$args);
 
             $this->injectMethodsAndProperties($object, $definition);
         } catch (NotFoundException $e) {