Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better exception messages #143

Closed
mnapoli opened this issue Jan 9, 2014 · 1 comment
Closed

Better exception messages #143

mnapoli opened this issue Jan 9, 2014 · 1 comment
Labels
Milestone

Comments

@mnapoli
Copy link
Member

@mnapoli mnapoli commented Jan 9, 2014

The messages for when an exception happen while building an object are always complex.

A way to help debug would be to dump the definition, e.g. this message:

Error while injecting 'ACLManager' in OrganizationController::aclManager.
The parameter 'contactEmail' of UserService::__construct has no value defined or guessable

Would become:

Error while injecting 'ACLManager' in OrganizationController::aclManager.
The parameter 'contactEmail' of UserService::__construct has no value defined or guessable.

Definition of UserService:

__construct(
    $mailer = entry 'Mailer'
    $contactEmail = UNKNOWN
)
setFoo(
    $bar = entry 'FooBar'
)
@mnapoli mnapoli added this to the 4.1 milestone Feb 5, 2014
mnapoli added a commit that referenced this issue Feb 22, 2014
@mnapoli
Copy link
Member Author

@mnapoli mnapoli commented Feb 22, 2014

Implemented in 4.1.

@mnapoli mnapoli closed this Feb 22, 2014
@mnapoli mnapoli mentioned this issue Feb 22, 2014
Merged
8 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.