Apply and enforce code style #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mnapoli
commented
Sep 19, 2015
mnapoli
commented
- remove file docblocks (those with the copyright and links): those were useless, I copied that from Symfony at the time but I don't really see the point
- enable StyleCI to enforce correct code styling in new commits and pull requests (let's try it, if it's too cumbersome we'll disable it)
- apply StyleCI fixes to fix code style everywhere at once (Applied fixes from StyleCI #331 merged into this branch)
This was referenced Sep 19, 2015
Applied fixes from StyleCI
|
Oh, wow 👍 |
|
@jdreesen if it's making contributors life harder let me know, the goal is to make it easier ;) |
|
We'll see. I haven't got any experience with StyleCI, yet. But a consistent code style is always a good thing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.