Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce stricter typing with PHP 7 #481

Merged
merged 1 commit into from Apr 19, 2017
Merged

Enforce stricter typing with PHP 7 #481

merged 1 commit into from Apr 19, 2017

Conversation

mnapoli
Copy link
Member

@mnapoli mnapoli commented Apr 19, 2017

Strict typing everywhere!

@mnapoli mnapoli added this to the 6.0 milestone Apr 19, 2017
@mnapoli mnapoli self-assigned this Apr 19, 2017
@mnapoli mnapoli merged commit 9f8c660 into master Apr 19, 2017
@mnapoli mnapoli deleted the php7-strict-types branch April 19, 2017 21:20
@holtkamp
Copy link
Contributor

holtkamp commented Apr 20, 2017

@mnapoli did you consider bumping the minimum required version to PHP 7.1 to allow nullable types?

This would enable to increase strictness even further, for example here:

    /**
     * @return bool|null
     */
    public function isLazy()
    {
        return $this->lazy;
    }
    /**
     * @return bool|null
     */
    public function isLazy(): ?bool
    {
        return $this->lazy;
    }

Combined with typed collections as described here, this makes a powerful combination 😄

@mnapoli
Copy link
Member Author

mnapoli commented Apr 26, 2017

@holtkamp, @Taluu, @avant1 I've opened #483 to discuss that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants