Fix #377 in 4.x branch #504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the pull request. Since 4.0 is not really maintained anymore I'd like to avoid having to release a new version, I've answered in mnapoli/silly#40 (comment) hopefully it can help. If we cannot solve mnapoli/silly#40 then I'll merge this and create a new release though so that you have a solution. |
|
mnapoli/silly#40 is closed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the fix for #377, specifically 6c7bea5, was intended to be included in php-di/php-di 4.4.9. However, that release was mis-tagged against master; 4.4.10 was used to address that, but does not include 6c7bea5. This is corroborated by inspecting this line.
Please merge this fix to the 4.x branch and tag it as 4.4.11. This will allow the 4.x branch to work under PHP 7.1. While I would like to use php-di/php-di 5 or 6 in my project, mnapoli/silly#40 is currently preventing me from doing so. Thanks in advance.