Increase support for compiling FactoryDefinitions and Closures #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
reviewed
Mar 11, 2019
mnapoli
reviewed
Mar 11, 2019
| $expression = $this->compileValue($definition->getExpression()); | ||
| $code = 'return \DI\Definition\StringDefinition::resolveExpression(' . $entryName . ', ' . $expression . ', $this->delegateContainer);'; | ||
| $code = 'return \DI\Definition\StringDefinition::resolveExpression(' . $compiledEntryName . ', ' . $expression . ', $this->delegateContainer);'; |
There was a problem hiding this comment.
Is this change affecting logic? (trying to assess whether there's a need to understand something behind this or if it's just a cosmetic change)
There was a problem hiding this comment.
Well, the original code "overwrote" the $entryName variable.
An entry named foo, became 'foo' (difficult to notice, but true), that is why I decided to use a separate variable name.
|
Closing per #648 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #648