Make compiled container (almost) idempotent #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a progressive counter for mapped methods/sub entries, container recompilation produces always the same result if definitions do not change. It's not fully idempotent because changing definitions order leads to a different container, even if functionally unchanged.
|
Nice idea 😸 |
mnapoli
reviewed
Oct 19, 2019
There was a problem hiding this comment.
Oh I love this! That's really clever and simple ❤️
Would you all agree that it solves the original problem? I understand that if the definition order changes then the compiled container changes, but that's not really a problem for deployment/scaling an application.
|
Thanks @diesse! Let's give this a go in a new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a progressive counter for mapped methods/sub entries, container recompilation produces always the same result if definitions do not change.
It's not fully idempotent because changing definitions order leads to a different container, even if functionally unchanged.
Partially fixes #604