-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autowiring-support for PHP7.4 typed properties #708
Conversation
I get a bunch of formatting errors on source files I did not touch, is this intentional? |
It looks like, phpstan needs to be pushed to PHP7.4 only - I am not sure if you want me to do this in this branch? If you update master, I'll happily rebase. |
That pull request is awesome! Thank you for covering all cases! I will try to sort out master, hang on ^^ |
👍 I updated master, you can rebase/merge it in your branch. |
024740b
to
22a6796
Compare
phpstan pointed to me to two issues, I now fixed (and squashed):
|
22a6796
to
8fea0c1
Compare
Yes that looks good to me. There is one last thing to fix regarding code formatting, I opened a code suggestion. |
The current implementation prioritizes `@var` and the `name` property of the `@Inject` annotation over the type of the property. This allows to still inject custom-named entries into the properties even in the presence of types.
b0ba638
to
9ef7b48
Compare
Thanks, missed this. PR is updated with the squashed change. |
Do we have an ETA on this being merged (and tagged incl. the other PR)? :) |
Ping :) -- I have a bunch of developers eagerly waiting for this feature and I'd rather not switch our projects to our forked repo. |
Sorry, I disable email notifications because I get so many of them every day, it creates a lot of anxiety :) Let's give that a go! |
Awesome, thanks. I'll give it a go in prod today. :) |
The current implementation prioritizes
@var
and thename
property of the@Inject
annotation over the type of the property. This allows to still inject custom-named entries into the properties even in the presence of types.Fixes #707