Replace the original Symfony EventDispatcher #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now uses an implementation that supports callbackInvoker Let AssociativeArrayResolver handle event parameter Use container instead of callbackInvoker Revert "Use container instead of callbackInvoker" This reverts commit d2a8af8. Send Container to parent Invoker
| @@ -28,6 +28,6 @@ public function __construct(ContainerInterface $container) | |||
| new TypeHintResolver, | |||
| new TypeHintContainerResolver($container), | |||
| new NumericArrayResolver, | |||
| ])); | |||
| ]), $container); | |||
There was a problem hiding this comment.
This looked like a bug to me, at least my implementation didn't work without this.
Without this, the CallbackInvoker doesn't send $container to it's parent, so when a call() was made, it wouldn't actually do a lookup in the container...
|
Tests are currently broken because of changes in Silex v2.0.2: silexphp/Silex@v2.0.1...v2.0.2 Fixing on silex/silex v2.0.1 makes tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now uses an implementation that uses callbackInvoker