Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'errorHandler' should get the settings.outputBuffering value #30

Closed
RyanNerd opened this issue Nov 14, 2017 · 1 comment
Closed

'errorHandler' should get the settings.outputBuffering value #30

RyanNerd opened this issue Nov 14, 2017 · 1 comment

Comments

@RyanNerd
Copy link

Here:
https://github.com/PHP-DI/Slim-Bridge/blob/master/src/config.php#L42

Should probably read:

->constructor(DI\get('settings.displayErrorDetails'), DI\get('settings.outputBuffering')),
@mnapoli
Copy link
Member

mnapoli commented Nov 14, 2017

Thanks, it seems this parameter was added in 3.9.0 (slimphp/Slim@6f6af26).

Feel free to send a pull request, since the parameter is optional everything still works as usual (nothing broke) so I'll add it to the end of my todo list ;)

RyanNerd pushed a commit to RyanNerd/Slim-Bridge that referenced this issue Nov 14, 2017
Default configuration includes the outputBuffering setting in the 'er…
b199a92 
…rorHandler' constructor.

Added code to test the change.

Closes PHP-DI#30
@RyanNerd RyanNerd mentioned this issue Nov 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mnapoli @RyanNerd