Optional parameters do not work with PHP 7.1 syntax

[odahcam]

Example:

class SomeController {
    function someAction(?int $id, $request) {}
}

Or:

class SomeController {
    function someAction(?int $id = null, $request) {}
}

These examples does not works, the injector throws an error saying that there's no given value for that parameter. As long as it's optional, something like null should be injected as the value.

[mnapoli]

There are tests covering that: https://github.com/PHP-DI/Slim-Bridge/blob/master/tests/RoutingTest.php#L46-L74 You may be onto an edge case.

Can you try without the ?, and with the optional parameter at the end?

[odahcam]

I asked my teamate @anologicon to test it.

[anologicon]

👍 Works:

class SomeController {
    function someAction($request, ?int $id = null) {}
}

class SomeController {
    function someAction($request, int $id = null) {}
}

👎 Doesn't Works:

class SomeController {
    function someAction($request, ?int $id) {}
}

Exception :

Exception has occurred.
Invoker\Exception\NotEnoughParametersException: Unable to invoke the callable because no value was given for parameter

[jworreth]

Hi there,

I'm facing the same issue with optional parameters. Here is a sample of my non-working code:

class ClassController
{
    public $mProxy;
    public function __construct(?Proxy $proxy = null)
    {
        $this->mProxy = $db ?? ProxyFactory::create();
    }
}

And this is the working sample of code:

class ClassController
{
    public $mProxy;
    public function __construct(Proxy $proxy)
    {
        $this->mProxy = $db ?? ProxyFactory::create();
    }
}

As I understand so far, the '?' (question mark) has no meaning to PHP-DI as the behaviour is the same whether I use it or not. My problem appears only when I write Proxy $proxy = null in the constructor of my ClassController.

Would it be possible to have a workaround ? or even more appreciated, a fix ?

Thanks

[mnapoli]

Hi, I haven't had time yet to work on that. However a pull request would be welcome.

[jworreth]

Thanks a lot for the quick answer, it's much appreciated !

In the meantime though, here is a temporary fix I am using from PHP-DI repo :
Issue 628

I've written a factory used only in my unit test to solve this issue.

Hope this will help someone in my case until a fix will show up :-)

[mnapoli]

Fixed by PHP-DI/Invoker#29