Added support for PSR-15 middleware resolving #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olver and \Slim\Interfaced\AdvancedCallableResolverInterface Fixes #51 and uses code supplied by kakenbok in #51 (comment)
|
Hmm, I think injecting second resolver might be overkill for the problem. The current issue is that Invoker throws exception that Slim doesn't expect and catch there, so fallback code is never reached. Might throwing the expected exception and letting Slim get on with it be a lighter solution? |
|
Possibly might be better improved upstream too, opened an issue there slimphp/Slim#3071 |
|
Thank you, we've merged #71 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51 by using the code supplied by kakenbok in #51 (comment). Added a test case that passes as well.