Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the method name in the test case for image to video conversion pull request #533

Merged
merged 1 commit into from
May 16, 2018

Conversation

pralhadstha
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #524
Related issues/PRs #524
License MIT

What's in this PR?

Fixing the wrong test method that was need to be amended on test case which was merged in #524

Why?

Building the test for the specific image to video conversion

@jens1o jens1o merged commit 0c1ed58 into PHP-FFMpeg:v1.x May 16, 2018
@jens1o
Copy link
Member

jens1o commented May 16, 2018

thanks, thought I had to do this myself

@pralhadstha
Copy link
Author

if the build was passing that wouldn't be a case. ;)

@jens1o
Copy link
Member

jens1o commented May 17, 2018

Yeah, I really need to fix all these problems, want to do this in the next two weeks, since I got (school) holidays. :)

jens1o added a commit that referenced this pull request Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants