Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix readme typo #694

Merged
merged 3 commits into from
Mar 2, 2021
Merged

fix readme typo #694

merged 3 commits into from
Mar 2, 2021

Conversation

h0rn3z0r
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
Related issues/PRs -
License MIT

@jens1o
Copy link
Member

jens1o commented Feb 25, 2020

Thanks!

Romain
Romain reviewed Mar 2, 2021
View reviewed changes
Copy link
Member

@Romain Romain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in this doc, the concat -safe 0 params are for videos with the exact same codecs.

If you look at the code, this is precisely what this feature does.

Therefore, the initial content was accurate.

@Romain Romain closed this Mar 2, 2021
@h0rn3z0r
Copy link
Contributor Author

h0rn3z0r commented Mar 2, 2021

Therefore, the initial content was accurate.

@Romain, I suggest you to review this section more carefully: https://github.com/PHP-FFMpeg/PHP-FFMpeg#concatenation
There are two code examples for opposite cases (same and different codecs) with identical description:

To concatenate videos encoded with the same codec, do as follow:

Clearly a mistake.

@Romain Romain reopened this Mar 2, 2021
@Romain
Copy link
Member

Romain commented Mar 2, 2021

@h0rn3z0r My bad, I read it to quickly. Your suggestion is completely valid.
Sorry for this mistake.

@Romain Romain merged commit 7a30ef4 into PHP-FFMpeg:master Mar 2, 2021
@h0rn3z0r h0rn3z0r deleted the patch-1 branch March 2, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Romain Romain Romain left review comments

@jens1o jens1o jens1o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@h0rn3z0r @jens1o @Romain