Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boolean types #779

Merged
merged 2 commits into from
Dec 23, 2020
Merged

Fix boolean types #779

merged 2 commits into from
Dec 23, 2020

Conversation

digilist
Copy link
Contributor

Q A
Bug fix? kind of, but no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none
Related issues/PRs none
License MIT

What's in this PR?

Some docblocks use Boolean as a type even though it should be bool and not an instance of Boolean class. This PR fixes this

Why?

I am fixing this because Psalm complains about an unknown type when using methods with this type:

ERROR: UndefinedDocblockClass - [...].php:37:14 - Docblock-defined class or interface FFMpeg\FFProbe\DataMapping\Boolean does not exist (see https://psalm.dev/200)
        if (!$format->has('duration')) {

@Romain Romain merged commit 7abb6d3 into PHP-FFMpeg:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Romain Romain Romain left review comments

Assignees
No one assigned
Labels
Enhancement semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@digilist @Romain