Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC] Upgraded dependencies, dropped support for anything below PHP 8.0. #849

Merged
merged 6 commits into from
Feb 9, 2022

Conversation

pascalbaljet
Copy link
Member

@pascalbaljet pascalbaljet commented Jan 31, 2022

This is a PR aiming to modernize the library. I've integrated the Alchemy Binary library, as the original repository seems dead.

  • Support for PHP 8.0 and 8.1
  • Support for Symfony 5.4 and 6.0
  • Support for psr/log v3
  • GitHub actions against FFmpeg 4.4 and 5.0
  • Integrated the Alchemy Binary library
  • Replaced neutron/temporary-filesystem with spatie/temporary-directory
  • PHPUnit 9.5
  • Removed Silex Service Provider
  • Removed the auto-generated docs

@UtechtDustin
Copy link

@romainneutron could please check this PR ? :-)

Copy link

@deluxetom deluxetom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, I'm glad you became a maintainer of this project!

The only thing I'm seeing is a lot of methods are missing a return type where it would be beneficial for PHP 8.1 but it can be added later.

Thank you!

@pascalbaljet
Copy link
Member Author

I've used this PR to power the next version of Laravel FFmpeg, which has a lot of integration tests, and everything seems to work fine. So unless there are some urgent issues with this PR, I'll merge it and tag a major version in the coming days.

@pascalbaljet pascalbaljet merged commit 111c153 into PHP-FFMpeg:master Feb 9, 2022
@pascalbaljet
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install on php8.1 and symfony6 Laravel 8 Installation -> Monolog 1.3 error
3 participants