Added exception if secret key or private and public key is missing #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messhias
approved these changes
Feb 21, 2022
|
@eschricker can we merge it? |
|
From my side it is fine. @mfn would you like to have a look at the changes? |
|
Will review soon! |
Messhias
approved these changes
Apr 6, 2022
mfn
reviewed
May 4, 2022
Comment on lines
+46
to
+48
| if(is_null($secret) && (is_null($keys['public']) || is_null($keys['private']))) { | ||
| throw new SecretMissingException(); | ||
| } |
There was a problem hiding this comment.
The only improvement I an think would be to include a nice message, pointing out which secret is missing specifically.
|
This seems like a breaking change for an app that uses this package only for authenticating users.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the secret key (symmetric algo) or private and public key (asymmetric algo) are missing, you will get a type mismatch error from Lcobucci (see #116).
Description
An own exception has been added which will be thrown, when the either the secret key or private/public key are missing. In that case you will get a better error message.
Fixes #116
Checklist:
CHANGELOG.md