Added command for generating certs #124
Conversation
| // check if laravel version Less than 5.4.17 | ||
| if (version_compare($this->laravel->version(), '5.4.17', '<')) { | ||
| return $this->laravel->basePath() . DIRECTORY_SEPARATOR . '.env'; | ||
| } |
There was a problem hiding this comment.
This can be removed, we only support L6+
There was a problem hiding this comment.
I have changed this in #145
| static $filepath = null; | ||
|
|
||
| if(is_null($filepath)) { | ||
| $filepath = $this->envPath(); | ||
| } |
There was a problem hiding this comment.
Is there a benefit to the static? I think we can just call $this->envPath() all the time?
There was a problem hiding this comment.
I have changed this in #145
| @@ -54,3 +54,39 @@ This will update your `.env` file with something like `JWT_SECRET=foobar` | |||
|
|
|||
| It is the key that will be used to sign your tokens. How that happens exactly will depend | |||
| on the algorithm that you choose to use. | |||
|
|
|||
| ### Generate certificate | |||
There was a problem hiding this comment.
The instruction are identical to the laravel-installation.md, aren't they?
Can we make a dedicated section for this somewhere, without duplicating this?
There was a problem hiding this comment.
I have changed this in #146
|
|
||
| // save certificates to disk | ||
| if (false === is_dir($directory)) { | ||
| mkdir($directory); |
There was a problem hiding this comment.
We should consider making it recursively to improve DX:
mkdir($directory, 0777, true);There was a problem hiding this comment.
I have changed this in #146
| $algo = $this->option('algo') ? $this->option('algo') : 'rsa'; | ||
| $bits = $this->option('bits') ? intval($this->option('bits')) : 4096; | ||
| $shaVariant = $this->option('sha') ? intval($this->option('sha')) : 512; | ||
| $passphrase = $this->option('passphrase') ? $this->option('passphrase') : null; |
There was a problem hiding this comment.
Not sure if providing the passphrase via command line is a good idea (think about shell history file).
Maybe it should be possible to ask() for this too?
E.g. --passphrase without providing one would ask for it.
There was a problem hiding this comment.
I have changed this in #146
Description
A new command was added, that can be used for generating certificates and updating the env-file.
Common code between the command for generating secrets and certs has been refactored into a trait.
Checklist:
CHANGELOG.md