Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: custom TTLs for each guard #223

Merged
merged 5 commits into from
Nov 10, 2023
Merged

FEAT: custom TTLs for each guard #223

merged 5 commits into from
Nov 10, 2023

Conversation

avidianity
Copy link
Contributor

Description

  1. Adds the ability to optionally define a custom TTL for each guard.
  2. Added a getter for ttl at JWTGuard.php
  3. Added null to return type in getTTL() at Factory.php

Fixes #164

Checklist:

  • I've added tests for my changes or tests are not applicable
  • I've changed documentations or changes are not required
  • I've added my changes to CHANGELOG.md

@Messhias
Copy link
Collaborator

Messhias commented Nov 9, 2023

@eschricker sounds good for me, what do you think?

@eschricker
Copy link
Contributor

Looks good to me

@Messhias Messhias merged commit 5f0f5f8 into PHP-Open-Source-Saver:main Nov 10, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Messhias Messhias Messhias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different TTL configurations for each guard
3 participants
@avidianity @Messhias @eschricker