New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix addMinutes to Carbon 3 #239

Merged

Messhias merged 1 commit into PHP-Open-Source-Saver:main from emtudo:main

Mar 19, 2024

Contributor

emtudo commented Mar 19, 2024

in Carbon 3, the return Utils::now()->addMinutes($this->ttl)->getTimestamp() line gives an error if it does not receive an integer.

This code corrects that, but it doesn't handle null values, I don't know why there is a null value.


          fix addMinutes to Carbon 3

de2b4f2

Messhias approved these changes

View reviewed changes

Messhias merged commit 195bd0c into PHP-Open-Source-Saver:main

33 checks passed

Contributor

mfn commented Mar 20, 2024

Nice, thanks @emtudo for the the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment