No longer suggest incorrect type hint

PHPCSStandards · Dec 4, 2023 · 366bd9f · 366bd9f
1 parent 3b05f87
commit 366bd9f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/Standards/Squiz/Sniffs/Commenting/FunctionCommentSniff.php b/src/Standards/Squiz/Sniffs/Commenting/FunctionCommentSniff.php
@@ -463,7 +463,7 @@ protected function processParams(File $phpcsFile, $stackPtr, $commentStart)
                     }
                 }
 
-                if ($suggestedTypeHint !== '' && isset($realParams[$pos]) === true) {
+                if ($suggestedTypeHint !== '' && isset($realParams[$pos]) === true && $param['var'] !== '') {
                     $typeHint = $realParams[$pos]['type_hint'];
 
                     // Remove namespace prefixes when comparing.

diff --git a/src/Standards/Squiz/Tests/Commenting/FunctionCommentUnitTest.php b/src/Standards/Squiz/Tests/Commenting/FunctionCommentUnitTest.php
@@ -102,7 +102,6 @@ public function getErrorList()
             792  => 1,
             794  => 1,
             797  => 1,
-            801  => 1,
             828  => 1,
             840  => 1,
             852  => 1,
@@ -134,10 +133,8 @@ public function getErrorList()
             1125 => 1,
             1138 => 1,
             1139 => 1,
-            1142 => 1,
             1144 => 1,
             1145 => 1,
-            1148 => 1,
             1151 => 1,
         ];